Board Thread:New Features/@comment-26339491-20191016152503/@comment-27345308-20191017164712

Andrewds1021 wrote: This burns my eyes on FANSUN, btw.

Andrewds1021 wrote: Are timestamps also preserved? Without those, it would be difficult keeping track of which thread came first. If you look at the [?namespace=2001 migrated Forum posts] of the user whose Discussions post I linked before, you'll see that timestamps were properly migrated too.

Andrewds1021 wrote: From previous discussions, I was under the impression that converted threads would be editable. Is that not true? Not exactly. Discussions saves post content as HTML. This means whatever is in the database for the HTML of the post is displayed directly to the user. For this to not be a huge security issue, they are removing non-whitelisted HTML tags and attributes from user input whenever a new post is created/edited. The Discussions migration script saves rendered HTML of Forum posts into the database directly, so some non-whitelisted tags/attributes appear in there that will get stripped once the post is edited (again, for security reasons).

For some reason, the old migration script also stripped  tags from rendered HTML, even though there was no way to insecurely insert one, and the only thing that achieved was screwing up what previously was the poll tag as you can see in the post I linked above.

Andrewds1021 wrote: Are the converted images treated differently from images that are posted new? If so, how? Also, is the image database shared between Discussions and the wiki. Like, can I use a 5-year-old image from the wiki in Discussions? If I post a new image in Discussions, does it also get added to the wiki? If so, does MediaWiki:Titleblacklist still get applied? Images in Discussions are a completely separate system from images uploaded to the wiki (the only same things between them being the image host and image review). You cannot set a title to your Discussions images, so the title blacklist does not apply. You also don't have the option of viewing "all Discussions images" as of yet.

By the way, the above gallery seems to be screwed up for two reasons:
 * 1) The migrated content contains HTML that is supposed to display an image after lazyloading of said image occurs. However, Discussions just doesn't have that lazyloading system and images remain undisplayed after migration.
 * 2) The images on there just seem to be embedded from the wiki images, so after migrating Forum posts to Discussions wikis will be left with a lot of unused files that, if they delete, will no longer work on Discussions (with no indication on what post were they posted on). Yes, the migration script really sucked that bad.

Andrewds1021 wrote: I don't see how you could preserve all the page info like history and whatnot. Am I misunderstanding what you are saying? Yes. The import tool allows you to attribute any edit to any user by editing the imported XML, and that can be used to turn page creations into edits on a single page by users who created these pages.

Andrewds1021 wrote: Since Discussions is not part of MediaWiki, do the same restrictions on HTML apply or is it a separate set of restrictions? As I mentioned above, Discussions HTML whitelist is at the moment stricter than MediaWiki's, as Discussions has way less features and valid user input to whitelist.

Andrewds1021 wrote: Either way, it seems like being able to edit the posts would be really nice if you have an ongoing discussion. Perhaps better HTML editing should be added to the Discussions to-do list. I don't see how do you expect to achieve this without opening major security holes. Did you mean whitelisting more tags/attributes in Discussions?